1. 15 6月, 2019 7 次提交
    • Nikolay Korovaiko's avatar
      fixes to make a profiling pipeline work · a3b49e99
      Nikolay Korovaiko 提交于
      clean up
      
      bettter tests
      
      address michael's feedback
      
      sink guard creation into the true arm of an if
      
      fix build failures
      
      more build errors after renaming a function
      
      missed one
      a3b49e99
    • Zachary DeVito's avatar
      19f0f90b
    • Edward Yang's avatar
      Define __setstate__ on _ConvNd to handle pre-padding_mode pickles. (#21687) · 029a9682
      Edward Yang 提交于
      Summary:
      Pull Request resolved: https://github.com/pytorch/pytorch/pull/21687
      ghimport-source-id: df49530d25239ac4d62eae83c5d7b0d8f00f836a
      
      Differential Revision: D15807402
      
      Pulled By: ezyang
      
      fbshipit-source-id: f51b221444afc4e017db7544642a9c0a7d2a3efb
      029a9682
    • Brian Vaughan's avatar
      Fix handling of kwargs from common method invocations (#21499) · 7284f448
      Brian Vaughan 提交于
      Summary:
      When kwargs are specified in a test defined via common_method_invocations, it doesn't work if there isn't also a positional argument (`{'foo':'foo'}` without a positional arg generates a python call like: `self.method(, foo=foo)`, erroring on the `,`). I wanted to test something in a different PR and noticed I couldn't.
      
      Also fixed some flake8 warnings I was seeing locally.
      
      I replaced `lambda x: x` with `ident` since it seems a bit cleaner to me, but happy to revert that if others don't agree?
      Pull Request resolved: https://github.com/pytorch/pytorch/pull/21499
      
      Differential Revision: D15826974
      
      Pulled By: nairbv
      
      fbshipit-source-id: a3f37c80ba2303c7d9ae06241df06c7475b64e36
      7284f448
    • Lu Fang's avatar
      Add ONNX py3 CI cases (#21715) · c1744a6c
      Lu Fang 提交于
      Summary:
      So far, we only have py2 ci for onnx. I think py3 support is important. And we have the plan to add onnxruntime backend tests, which only supports py3.
      Pull Request resolved: https://github.com/pytorch/pytorch/pull/21715
      
      Reviewed By: bddppq
      
      Differential Revision: D15796885
      
      Pulled By: houseroad
      
      fbshipit-source-id: 8554dbb75d13c57b67ca054446a13a016983326c
      c1744a6c
    • xiaobing.zhang's avatar
      Add aten mkldnn zero_ operator (#20573) · c06ccbe6
      xiaobing.zhang 提交于
      Summary:
      ### mkldnn backward ops list:
       - [ ] \(https://github.com/pytorch/pytorch/pull/20567) Add aten mkldnn conv2d backward operator 💛
       - [ ] \(https://github.com/pytorch/pytorch/pull/20570) Add aten mkldnn backward ops: relu, linear and reshape 💛
       - [ ] \(https://github.com/pytorch/pytorch/pull/20571) Add aten mkldnn backward ops: max_pool2d, avg_pool2d and adaptive_avg_poo2d 💛
       - [ ] \(https://github.com/pytorch/pytorch/pull/20572) Add aten mkldnn batchnorm backward operator 💛
       - [ ] \(https://github.com/pytorch/pytorch/pull/20573) Add aten mkldnn zero_ operator:yellow_heart:
       - [ ] \(https://github.com/pytorch/pytorch/pull/20575) Add mkldnn mul operator 💚
      Pull Request resolved: https://github.com/pytorch/pytorch/pull/20573
      
      Differential Revision: D15820477
      
      Pulled By: bddppq
      
      fbshipit-source-id: 35d95f5b4e013c8db1911f52148550a2e40a2e68
      c06ccbe6
    • Tongzhou Wang's avatar
      rebuild_storage_fd retry on EINTR (#21723) · bc628102
      Tongzhou Wang 提交于
      Summary:
      Some data loader tests are flaky on py 2 with the following error
      ```
      Jun 12 22:17:31 Traceback (most recent call last):
      Jun 12 22:17:31   File "test_dataloader.py", line 798, in test_iterable_dataset
      Jun 12 22:17:31     fetched = sorted([d.item() for d in dataloader_iter])
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 697, in __next__
      Jun 12 22:17:31     idx, data = self._get_data()
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 664, in _get_data
      Jun 12 22:17:31     success, data = self._try_get_data()
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 617, in _try_get_data
      Jun 12 22:17:31     data = self.data_queue.get(timeout=timeout)
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/multiprocessing/queues.py", line 135, in get
      Jun 12 22:17:31     res = self._recv()
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/site-packages/torch/multiprocessing/queue.py", line 22, in recv
      Jun 12 22:17:31     return pickle.loads(buf)
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/pickle.py", line 1382, in loads
      Jun 12 22:17:31     return Unpickler(file).load()
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/pickle.py", line 858, in load
      Jun 12 22:17:31     dispatch[key](self)
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/pickle.py", line 1133, in load_reduce
      Jun 12 22:17:31     value = func(*args)
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/site-packages/torch/multiprocessing/reductions.py", line 274, in rebuild_storage_fd
      Jun 12 22:17:31     fd = multiprocessing.reduction.rebuild_handle(df)
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/multiprocessing/reduction.py", line 157, in rebuild_handle
      Jun 12 22:17:31     new_handle = recv_handle(conn)
      Jun 12 22:17:31   File "/opt/python/2.7.9/lib/python2.7/multiprocessing/reduction.py", line 83, in recv_handle
      Jun 12 22:17:31     return _multiprocessing.recvfd(conn.fileno())
      Jun 12 22:17:31 OSError: [Errno 4] Interrupted system call
      ```
      
      Apparently, Python 2.7's `recvfd` calls `recvmsg` without EINTR retry: https://github.com/python/cpython/blob/2.7/Modules/_multiprocessing/multiprocessing.c#L174
      So we should call it with an outer try-catch loop.
      Pull Request resolved: https://github.com/pytorch/pytorch/pull/21723
      
      Differential Revision: D15806247
      
      Pulled By: ezyang
      
      fbshipit-source-id: 16cb661cc0fb418fd37353a1fef7ceeb634f02b7
      bc628102
  2. 14 6月, 2019 31 次提交
  3. 13 6月, 2019 2 次提交